feat: Mirror Descent algorithm#12
Merged
BatyLeo merged 11 commits intoJun 21, 2026
Merged
Conversation
BatyLeo
reviewed
Jun 1, 2026
BatyLeo
left a comment
BatyLeo
left a comment
Member
There was a problem hiding this comment.
Thank you for opening the PR, this is a good start!
Most of comment below are minor details, except a couple correctness bugs that need to be addressed (see comments).
In addition to the comments:
- We may want to have a documentation page providing a concise explanation of the algorithm, as well as a tutorial showcasing its use
- Tests for the algorithm are needed, maybe some on the toy contextual argmax, and others on the stochastic VSP to check the different kwargs are correctly provided.
- Currently failing tests are formatting and JET (which is detecting the correctness bugs caused by methods called incorrectly)
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A generic implementation of Mirror Descent.
The first iteration is pure imitation learning.